-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update proxyType values to match w3c spec #13285
base: trunk
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13285 +/- ##
==========================================
+ Coverage 57.99% 58.12% +0.12%
==========================================
Files 88 88
Lines 5338 5335 -3
Branches 224 224
==========================================
+ Hits 3096 3101 +5
+ Misses 2018 2010 -8
Partials 224 224 ☔ View full report in Codecov by Sentry. |
04c0159
to
feaa53c
Compare
I feel like I read something completely different every time I look at the spec:
Grid is deserializing the empty Proxy and failing, so I need to remove the errors I'm throwing here. 😂 |
@titusfortner what is left to do here? |
CI Failure Feedback 🧐(Checks updated until commit 5523d9f)
|
Description
Motivation and Context
Making the libraries consistent between languages and updating to match w3c behavior.
Notes